<html>
<head><meta charset="utf-8"><title>2020-11-30 to 12-06 · t-release/triage · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/index.html">t-release/triage</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html">2020-11-30 to 12-06</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218285944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218285944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218285944">(Nov 30 2020 at 13:31)</a>:</h4>
<p>Triage reports for the week starting 30.11.2020. Monthly meeting will be held on <time datetime="2020-12-02T16:00:00Z">2020-12-02T17:00:00+01:00</time></p>



<a name="218312868"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218312868" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> John Simon <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218312868">(Nov 30 2020 at 16:50)</a>:</h4>
<p><em>S-waiting-on-author</em><br>
<a href="https://github.com/rust-lang/rust/pull/78454">https://github.com/rust-lang/rust/pull/78454</a> - assigned back to bugadani because it looks like this PR needs more work. <br>
<a href="https://github.com/rust-lang/rust/pull/76066">https://github.com/rust-lang/rust/pull/76066</a> - assigned back to author pickfire to resolve merge conflict... jyn514 left a comment • "crlf0710 this needs a new reviewer, I think Lukas has left the libs team."<br>
<a href="https://github.com/rust-lang/rust/pull/78181">https://github.com/rust-lang/rust/pull/78181</a> - assigned back to author GuillaumeGomez because of build failure, not pinging<br>
<a href="https://github.com/rust-lang/rust/pull/78928">https://github.com/rust-lang/rust/pull/78928</a> - assigned back to author simonvandel for merge conflicts. but <br>
<a href="https://github.com/rust-lang/rust/pull/77035">https://github.com/rust-lang/rust/pull/77035</a> - assinged to mibac138 to fix merge conflicts<br>
<a href="https://github.com/rust-lang/rust/pull/76215">https://github.com/rust-lang/rust/pull/76215</a> - estebank PR, could be closed maybe? "Aaron1011 commented on Sep 12 - Personally, I'd prefer if we limited this to cases where the previous output is potentially confusing, as I described in my comment. However, I don't feel very strongly about this, so I'll leave it up to you to decide." <br>
<a href="https://github.com/rust-lang/rust/pull/76130">https://github.com/rust-lang/rust/pull/76130</a> - WIP PR, not doing anything<br>
<a href="https://github.com/rust-lang/rust/pull/76301">https://github.com/rust-lang/rust/pull/76301</a> - matklad PR, merge conflict, not pinging<br>
<a href="https://github.com/rust-lang/rust/pull/78177">https://github.com/rust-lang/rust/pull/78177</a> - From another comment it looks like ecstatic-morse is no longer active - but was still assigned this PR to review, still assigned to author </p>
<p><em>S-waiting-on-review</em><br>
<a href="https://github.com/rust-lang/rust/pull/78399">https://github.com/rust-lang/rust/pull/78399</a> - looks like a test environment failure - oli-obk commented 17 days ago  - cc rust-lang/clippy maybe we should revisit our test suite? <br>
<a href="https://github.com/rust-lang/rust/pull/79012">https://github.com/rust-lang/rust/pull/79012</a> - waiting on review from estebank<br>
<a href="https://github.com/rust-lang/rust/pull/77633">https://github.com/rust-lang/rust/pull/77633</a> - still waiting on review but has sat idle for a month<br>
<a href="https://github.com/rust-lang/rust/pull/75414">https://github.com/rust-lang/rust/pull/75414</a> - still waiting on review from eddyb, also idle for over a month<br>
<a href="https://github.com/rust-lang/rust/pull/77530">https://github.com/rust-lang/rust/pull/77530</a> - unsure what to do with this, maybe it should be closed because the work is going to be added elsewhere? pinged author MikailBag<br>
<a href="https://github.com/rust-lang/rust/pull/76808">https://github.com/rust-lang/rust/pull/76808</a> - still waiting on review from matklad<br>
<a href="https://github.com/rust-lang/rust/pull/79015">https://github.com/rust-lang/rust/pull/79015</a> - still waiting on review from KodrAus</p>



<a name="218784202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218784202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218784202">(Dec 04 2020 at 02:32)</a>:</h4>
<h1>S-waiting-on-review</h1>
<p><a href="https://github.com/rust-lang/rust/issues/78399">#78399</a> 21 days - unsure; seems like there was a weird bors CI failure that can't be easily fixed? - assignee: oli-obk<br>
<a href="https://github.com/rust-lang/rust/issues/79012">#79012</a> 21 days - this is a perf-oriented PR IIUC but perf was negligible - assignee: estebank<br>
<a href="https://github.com/rust-lang/rust/issues/77801">#77801</a> 18 days - seems like backported to beta but not merged to master? confusing <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span> - <strong>seems like this fixes UB in <code>std</code>, so it's an important PR</strong> - assignee: withoutboats<br>
<a href="https://github.com/rust-lang/rust/issues/79084">#79084</a> 17 days - reassigned from estebank to oli-obk since I think oli's a better reviewer for it</p>
<h1>S-waiting-on-author</h1>
<p><a href="https://github.com/rust-lang/rust/issues/76301">#76301</a> Sept 13 - all this needs is a rebase; pinged author (matklad) - assignee: jonas-schievink<br>
<a href="https://github.com/rust-lang/rust/issues/76723">#76723</a> Oct 26  - author needs to address review - author <em>is</em> a Rust team member (jonas-schievink), but it's been 6 weeks so I pinged - assignee: oli-obk<br>
<a href="https://github.com/rust-lang/rust/issues/78177">#78177</a> 20 days - waiting on review; re-assigned to jyn514<br>
<a href="https://github.com/rust-lang/rust/issues/77307">#77307</a> Oct 28  - author (lcnr) needs to find time to work on it (as of Oct 28) - no ping - assignee: wesleywiser<br>
<a href="https://github.com/rust-lang/rust/issues/77377">#77377</a> 17 days - DPC pinged author (ecstatic-morse) 17 days ago; no reply since - assignee: pnkfelix</p>



<a name="218784430"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218784430" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218784430">(Dec 04 2020 at 02:33)</a>:</h4>
<p><strong>Update for <a href="https://github.com/rust-lang/rust/issues/77801">#77801</a>:</strong> Mark-Simulacrum just posted this:</p>
<blockquote>
<p>Going to go ahead and renominate for 1.49 backport (will do that this weekend). Would be great to make some progress here though.</p>
</blockquote>



<a name="218784816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218784816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218784816">(Dec 04 2020 at 02:34)</a>:</h4>
<p><strong>Update for <a href="https://github.com/rust-lang/rust/issues/79012">#79012</a>:</strong> Author (<span class="user-mention silent" data-user-id="306073">Tyson Nottingham</span>) just posted this:</p>
<blockquote>
<p>Yeah, I don't have strong feelings on whether or not to push forward with this. I'll note that cycles, cpu-clock, and task-clock stats saw moderate improvements even though instruction counts saw very small improvements. But it's possible that was just luck with the variance.</p>
</blockquote>



<a name="218794995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218794995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218794995">(Dec 04 2020 at 05:09)</a>:</h4>
<p>fyi I think <span class="user-mention silent" data-user-id="118594">ecstatic-morse</span> is taking a break from rust for a while</p>



<a name="218795001"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218795001" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218795001">(Dec 04 2020 at 05:09)</a>:</h4>
<blockquote>
<p><a href="https://github.com/rust-lang/rust/issues/78177">#78177</a> 20 days - waiting on review; re-assigned to jyn514</p>
</blockquote>
<p>taking a look at this now, this is a fun pr to review :) lots of code archeology</p>



<a name="218795745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218795745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218795745">(Dec 04 2020 at 05:29)</a>:</h4>
<p>done, wow that was a lot of git magic <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="218808768"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218808768" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218808768">(Dec 04 2020 at 09:17)</a>:</h4>
<p>re <a href="https://github.com/rust-lang/rust/issues/77801">#77801</a>: boats doesn't have much time to review things, but i'm not sure who else could review this. but yeah, bit of a weird situation that this is backported to both 1.48 and 1.49, but not approved for nightly.</p>



<a name="218833929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218833929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218833929">(Dec 04 2020 at 13:44)</a>:</h4>
<p><span class="user-mention" data-user-id="310399">@Mara</span> do you think you could bring it up at a libs meeting perhaps? I could take a stab at it but I'm not sure how I feel overriding/interpreting boats' concerns on Pin usage</p>



<a name="218834443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218834443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218834443">(Dec 04 2020 at 13:49)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Yeah good idea, although boats said in an email this week they won't be joining any meetings until january.</p>
<p>It came up shortly during a meeting a while ago, while talking about general guidelines for PRs involving Pin. But we didn't go into this PR specifically much. boats just said they still needed to take a closer look at it.</p>



<a name="218834558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218834558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218834558">(Dec 04 2020 at 13:50)</a>:</h4>
<p>you know -- I think we should just land it on master</p>



<a name="218834564"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218834564" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218834564">(Dec 04 2020 at 13:50)</a>:</h4>
<p>it's not like we can't revert</p>



<a name="218834578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218834578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218834578">(Dec 04 2020 at 13:50)</a>:</h4>
<p>Can you reassign to me?</p>



<a name="218840059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/2020-11-30%20to%2012-06/near/218840059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/2020-11-30.20to.2012-06.html#218840059">(Dec 04 2020 at 14:38)</a>:</h4>
<p>Dec 4th, 2020, Friday.<br>
S-waiting-on-review</p>
<p><a href="https://github.com/rust-lang/rust/pull/75522">https://github.com/rust-lang/rust/pull/75522</a>  ollie27<br>
<a href="https://github.com/rust-lang/rust/pull/79085">https://github.com/rust-lang/rust/pull/79085</a>  KodrAus<br>
<a href="https://github.com/rust-lang/rust/pull/72160">https://github.com/rust-lang/rust/pull/72160</a>   KodrAus<br>
<a href="https://github.com/rust-lang/rust/pull/79174">https://github.com/rust-lang/rust/pull/79174</a>   withoutboats  - should this be reassigned?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>